Add git config menu with scope switching#5137
Open
postgnostic wants to merge 1 commit intojesseduffield:masterfrom
Open
Add git config menu with scope switching#5137postgnostic wants to merge 1 commit intojesseduffield:masterfrom
postgnostic wants to merge 1 commit intojesseduffield:masterfrom
Conversation
7803203 to
9b3f1d0
Compare
Author
|
ok should be ready now |
Author
|
@stefanhaller I am sorry for the ping but I just wanted to ask if there is something I am missing/forgetting to get this reviewed/merged |
Collaborator
|
No need to be sorry, pinging is fine! I don't really have time to deal with all incoming PRs right now, and I had to focus on the work to fix the problems related to updating tcell in the past few weeks. A little bit of early feedback after playing with this very briefly: it looks like a nice feature, but I also think it still has quite a number of UX/UI issues, and I'm not really sure I feel like spending time and energy on helping resolve those. Have you considered implementing this as a standalone tool? That way you wouldn't be blocked by me not having time to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Adds a Git config menu (global keybinding ;) for viewing and editing git config values in a tree view. Supports
switching scope (local/global/system) via l/g/s or ←/→, shows the active scope in the header, persists expanded
sections, and includes common keys even when unset.
Notes
if tests could set these locally or reuse the repo’s local config.
Please check if the PR fulfills these requirements
go generate ./...)